Conversation
Signed-off-by: Mounil <mounilkankhara@gmail.com>
Prepare for transition to using Wiktionary for translations by replacing all "not_in_wikidata" string keys with "not_in_wiktionary" across all language interface files and UI components. Changes apply to: - 17 language-specific string.xml files - KeyboardUIManager.kt UI component Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Mounil <mounilkankhara@gmail.com>
Signed-off-by: Mounil <mounilkankhara@gmail.com>
Thank you for the pull request! 💙The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
First PR Commit Check
- The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
- The contributor's name and icon in remote commits should be the same as what appears in the PR
- If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have forgit config user.emailin their local Scribe-Android repo (can be set withgit config --global user.email "GITHUB_EMAIL")
|
Hey, @andrewtavis pls review and let me know in case of any changes! |
|
Thanks for the PR here, @Mounil2005 :) We have a couple of instructions here based on a discussion we had in our most recent dev sync:
Could you do the following:
CC @catreedle and @angrezichatterbox 👋 Hope the above makes sense to you two :) |
|
Got it, working on it! |
Signed-off-by: Mounil <mounilkankhara@gmail.com>
|
Hey @andrewtavis, I have implemented the changes, pls let me know in case of any changes!! |
|
Hi @andrewtavis, just a gentle reminder about this PR. Happy to adjust anything needed, thanks! |
Hey |
|
Thanks for the reminder @Mounil2005 and thanks for the review request, @angrezichatterbox :) @angrezichatterbox, let me know if you have a moment to sit for a review of this later this week. I'll do a quick review now and maybe you can do the changes in the coming days, @Mounil2005? |
| const val SPACE_BAR = "space" | ||
| const val LANGUAGE = "English" | ||
| const val INVALID_COMMAND_MSG = "Not in Wikidata" | ||
| const val INVALID_COMMAND_MSG = "Not in Wiktionary" |
There was a problem hiding this comment.
We don't need INVALID_COMMAND_MSG and INVALID_COMMAND_MSG_WIKTIONARY, so feel free to remove INVALID_COMMAND_MSG. Ideally these variables would be ordered as you have them with the Wikidata ones first.
There was a problem hiding this comment.
You can do this removal of INVALID_COMMAND_MSG for all files :)
| const val INVALID_COMMAND_MSG = "Pas dans Wikidata" | ||
| const val INVALID_COMMAND_MSG = "Pas dans Wiktionary" | ||
| const val INVALID_COMMAND_MSG_WIKIDATA = "Pas dans Wikidata" | ||
| const val INVALID_COMMAND_TEXT_WIKIDATA_1 = |
There was a problem hiding this comment.
Ideally we'd move over the texts that we already have for Wikidata in the various languages. As of now we have the English text for all of the Wikidata ones. Could you check the Scribe-i18n project for what these texts should be in the respective languages?
| <string name="i18n.app.keyboard.not_in_wikidata.explanation_1">Wikidata هي قاعدة بيانات معرفية يتم تحريرها بشكل تعاوني ويتم إدارتها من قبل مؤسسة ويكيميديا. تعمل كمصدر للبيانات المفتوحة لمشاريع مثل ويكيبيديا والعديد من المشاريع الأخرى.</string> | ||
| <string name="i18n.app.keyboard.not_in_wikidata.explanation_2">يستخدم Scribe بيانات اللغة من Wikidata للعديد من ميزاته الأساسية. نحصل على معلومات مثل أجناس الأسماء، وتصريف الأفعال والمزيد!</string> | ||
| <string name="i18n.app.keyboard.not_in_wikidata.explanation_3">يمكنك إنشاء حساب في wikidata.org للانضمام إلى المجتمع الذي يدعم Scribe والعديد من المشاريع الأخرى. ساعدنا في تقديم المعلومات المجانية للعالم!</string> | ||
| <string name="i18n.app.keyboard.not_in_wiktionary.explanation_1">ويكاموس هو قاموس تعاوني يتم تحريره بشكل جماعي ويتم إدارته من قبل مؤسسة ويكيميديا. يوفر تعريفات الكلمات ومعانيها بعدة لغات. </string> |
There was a problem hiding this comment.
Can you revert all changes to the string.xml files? I'll remove these strings in Scribe-i18n and bring the new changes back in.
|
Re the above comment, if you'd like to do a PR to Scribe-i18n as well to support with this, you could send along a PR that removes |
|
And one final thing for now - we have the 
Could you add an |
|
Please let us know if you have any questions! Thanks for your efforts so far 😊 |
3 participants
Contributor checklist
./gradlew lintKotlin detekt testcommand as directed in the testing section of the contributing guideDescription
This pull request prepares Scribe-Android for the migration from Wikidata to Wiktionary as the data source for translations. All string references have been updated from
not_in_wikidatatonot_in_wiktionary.Main changes:
string.xmlfiles (Arabic, Bengali, German, Spanish, French, Hindi, Indonesian, Kannada, Korean, Marathi, Portuguese, Swedish, Tamil, Telugu, Turkish, and English)KeyboardUIManager.ktto reference the new Wiktionary string keysThe string content itself remains unchanged as it will be updated separately. These changes ensure the app infrastructure is ready to display Wiktionary-related messages when the backend switches to that data source.
Related issue